[media] omap3isp: Fix error return code in probe function
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 4 Sep 2012 16:14:25 +0000 (13:14 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Sep 2012 17:18:54 +0000 (14:18 -0300)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
[laurent.pinchart@ideasonboard.com Replaced EBUSY with ENODEV]
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/omap3isp/isp.c

index e0096e07dbdc51e78b1117860379e40ad50aa5ca..d7aa513dcc8deace0704b37c5c378968ff558b37 100644 (file)
@@ -2102,8 +2102,10 @@ static int __devinit isp_probe(struct platform_device *pdev)
        if (ret < 0)
                goto error;
 
-       if (__omap3isp_get(isp, false) == NULL)
+       if (__omap3isp_get(isp, false) == NULL) {
+               ret = -ENODEV;
                goto error;
+       }
 
        ret = isp_reset(isp);
        if (ret < 0)