drm/vmwgfx: Delete an unnecessary check before the function call "vfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 22 Jul 2016 11:31:00 +0000 (13:31 +0200)
committerSean Paul <seanpaul@chromium.org>
Fri, 22 Jul 2016 15:23:40 +0000 (11:23 -0400)
The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/8060f2e9-5070-3c10-d55c-dc058e4ca20d@users.sourceforge.net
Link: http://patchwork.freedesktop.org/patch/msgid/f1a0fd83-4320-f3db-e1bb-3b9832a4429f@users.sourceforge.net
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

index 1a1a87cbf1097988bc60f91bd6debb872211908d..dc5beff2b4aaff83c18dc77187647102efea5266 100644 (file)
@@ -3625,9 +3625,7 @@ static int vmw_resize_cmd_bounce(struct vmw_sw_context *sw_context,
                                   (sw_context->cmd_bounce_size >> 1));
        }
 
-       if (sw_context->cmd_bounce != NULL)
-               vfree(sw_context->cmd_bounce);
-
+       vfree(sw_context->cmd_bounce);
        sw_context->cmd_bounce = vmalloc(sw_context->cmd_bounce_size);
 
        if (sw_context->cmd_bounce == NULL) {