x86, perf: Fix NULL deref on not assigned x86_pmu
authorCyrill Gorcunov <gorcunov@gmail.com>
Thu, 11 Mar 2010 21:50:16 +0000 (00:50 +0300)
committerIngo Molnar <mingo@elte.hu>
Fri, 12 Mar 2010 09:18:42 +0000 (10:18 +0100)
In case of not assigned x86_pmu and software events NULL dereference may
being hit via x86_pmu::schedule_events method.

Fix it by checking if x86_pmu is initialized at all.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <20100311215016.GG25162@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/cpu/perf_event.c

index e6a3f5f81c96b7c2f203b87840ad2917907f639b..5586a02067d81bf6596463792e10a163441cfe7a 100644 (file)
@@ -1269,6 +1269,9 @@ int hw_perf_group_sched_in(struct perf_event *leader,
        int assign[X86_PMC_IDX_MAX];
        int n0, n1, ret;
 
+       if (!x86_pmu_initialized())
+               return 0;
+
        /* n0 = total number of events */
        n0 = collect_events(cpuc, leader, true);
        if (n0 < 0)