regulator: wm8350: Do not hardcode return value
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 18 Feb 2014 10:40:57 +0000 (16:10 +0530)
committerMark Brown <broonie@linaro.org>
Wed, 19 Feb 2014 04:24:12 +0000 (13:24 +0900)
Propagate the error value returned by the function instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/wm8350-regulator.c

index de7b9c73e3fa09f3b14db1c5d8949ca99a37c352..7ec7c390eedaa1085eeb03d4adfce33f7f1b4531 100644 (file)
@@ -361,7 +361,7 @@ static int wm8350_dcdc_set_suspend_voltage(struct regulator_dev *rdev, int uV)
 
        sel = regulator_map_voltage_linear(rdev, uV, uV);
        if (sel < 0)
-               return -EINVAL;
+               return sel;
 
        /* all DCDCs have same mV bits */
        val = wm8350_reg_read(wm8350, volt_reg) & ~WM8350_DC1_VSEL_MASK;
@@ -574,7 +574,7 @@ static int wm8350_ldo_set_suspend_voltage(struct regulator_dev *rdev, int uV)
 
        sel = regulator_map_voltage_linear_range(rdev, uV, uV);
        if (sel < 0)
-               return -EINVAL;
+               return sel;
 
        /* all LDOs have same mV bits */
        val = wm8350_reg_read(wm8350, volt_reg) & ~WM8350_LDO1_VSEL_MASK;