staging: Fix bdops->check_events() misconversion in cyasblkdev_block.c
authorTejun Heo <tj@kernel.org>
Sat, 26 Mar 2011 18:52:59 +0000 (19:52 +0100)
committerJens Axboe <jaxboe@fusionio.com>
Sat, 26 Mar 2011 18:52:59 +0000 (19:52 +0100)
Commit cafb0bfca1 (staging: Convert to bdops->check_events())
incorrectly set bd->user_disk_0->events while initializing
bd->user_disk_1.  Fix it.

The problem was spotted by Milton's suspect code pattern detector.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
drivers/staging/westbridge/astoria/block/cyasblkdev_block.c

index 842cd9214a5ec120989e8a339ab158433dff5b91..289729daba80a5dffec1e473e189bc9b787a88ae 100644 (file)
@@ -1191,7 +1191,7 @@ static int cyasblkdev_add_disks(int bus_num,
                bd->user_disk_1->first_minor = (devidx + 1) << CYASBLKDEV_SHIFT;
                bd->user_disk_1->minors = 8;
                bd->user_disk_1->fops = &cyasblkdev_bdops;
-               bd->user_disk_0->events = DISK_EVENT_MEDIA_CHANGE;
+               bd->user_disk_1->events = DISK_EVENT_MEDIA_CHANGE;
                bd->user_disk_1->private_data = bd;
                bd->user_disk_1->queue = bd->queue.queue;
                bd->dbgprn_flags = DBGPRN_RD_RQ;