ANDROID: sdcardfs: remove unnecessary call to do_munmap
authorDaniel Rosenberg <drosen@google.com>
Fri, 10 Mar 2017 05:14:45 +0000 (21:14 -0800)
committerDaniel Rosenberg <drosen@google.com>
Tue, 30 Jan 2018 03:40:08 +0000 (19:40 -0800)
Adapted from wrapfs
commit 5be6de9ecf02 ("Wrapfs: use vm_munmap in ->mmap")
commit 2c9f6014a8bb ("Wrapfs: remove unnecessary call
to vm_unmap in ->mmap")

Code is unnecessary and causes deadlocks in newer kernels.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
Signed-off-by: Daniel Rosenberg <drosen@google.com>
Bug: 35766959
Change-Id: Ia252d60c60799d7e28fc5f1f0f5b5ec2430a2379

fs/sdcardfs/file.c

index eee4eb5896e5fef41f4ae3fcd7f79cf1a02c00a5..7e2c50b30782da51b2e05e73367a0124d878936f 100644 (file)
@@ -176,12 +176,6 @@ static int sdcardfs_mmap(struct file *file, struct vm_area_struct *vma)
                        goto out;
                }
                saved_vm_ops = vma->vm_ops; /* save: came from lower ->mmap */
-               err = do_munmap(current->mm, vma->vm_start,
-                               vma->vm_end - vma->vm_start);
-               if (err) {
-                       pr_err("sdcardfs: do_munmap failed %d\n", err);
-                       goto out;
-               }
        }
 
        /*