mtd: spi-nor: hisi: do not ignore clk_prepare_enable() failure
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Fri, 17 Feb 2017 22:08:17 +0000 (01:08 +0300)
committerCyrille Pitchen <cyrille.pitchen@atmel.com>
Tue, 7 Mar 2017 20:45:48 +0000 (21:45 +0100)
hisi_spi_nor_probe() ignores clk_prepare_enable() error code.
The patch fixes that.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
drivers/mtd/spi-nor/hisi-sfc.c

index 20378b0d55e98937528e025c03bb43c5b5c497a6..a286350627a663fc878245e18fbbb328ac7aa65f 100644 (file)
@@ -448,8 +448,11 @@ static int hisi_spi_nor_probe(struct platform_device *pdev)
        if (!host->buffer)
                return -ENOMEM;
 
+       ret = clk_prepare_enable(host->clk);
+       if (ret)
+               return ret;
+
        mutex_init(&host->lock);
-       clk_prepare_enable(host->clk);
        hisi_spi_nor_init(host);
        ret = hisi_spi_nor_register_all(host);
        if (ret)