staging: r8192ee: Fix kernel WARN splat associated with rate control
authorLarry Finger <Larry.Finger@lwfinger.net>
Mon, 26 May 2014 19:06:04 +0000 (14:06 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 May 2014 03:17:51 +0000 (20:17 -0700)
The 0day kernel testing robot got the kernel warning caused by trying
to register a particular rate-control algorithm more than once. I believe
that the core already protects against a particular driver doing the
registration more than once, but an analysis of the code reveals that
the identical name is used for the rtlwifi drivers in the regular
wireless tree, and the staging drivers r8192ee and r8821ae. The fix
is to rename the algorithm used in r8192ee.

Reported-by: Jet Chen <jet.chen@intel.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Tested-by: Jet Chen <jet.chen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192ee/rc.c

index f0ce6a99ab00cbdac0969873f81af6ab54ec6ef0..c4c34ddcf8cd50a84319db63b2c84b7c79a6913b 100644 (file)
@@ -267,7 +267,7 @@ static void rtl_rate_free_sta(void *rtlpriv,
 }
 
 static struct rate_control_ops rtl_rate_ops = {
-       .name = "rtl_rc",
+       .name = "rtl_rc_92e",
        .alloc = rtl_rate_alloc,
        .free = rtl_rate_free,
        .alloc_sta = rtl_rate_alloc_sta,