bcache: Don't reinvent the wheel but use existing llist API
authorByungchul Park <byungchul.park@lge.com>
Wed, 6 Sep 2017 06:25:54 +0000 (14:25 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 6 Sep 2017 14:17:33 +0000 (08:17 -0600)
Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Acked-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/closure.c

index 864e673aec39598d2f7f99e43c5b3168f2c1d736..7d5286b05036976059c3af6c7277a987b457c59d 100644 (file)
@@ -70,21 +70,10 @@ void __closure_wake_up(struct closure_waitlist *wait_list)
        list = llist_del_all(&wait_list->list);
 
        /* We first reverse the list to preserve FIFO ordering and fairness */
-
-       while (list) {
-               struct llist_node *t = list;
-               list = llist_next(list);
-
-               t->next = reverse;
-               reverse = t;
-       }
+       reverse = llist_reverse_order(list);
 
        /* Then do the wakeups */
-
-       while (reverse) {
-               cl = container_of(reverse, struct closure, list);
-               reverse = llist_next(reverse);
-
+       llist_for_each_entry(cl, reverse, list) {
                closure_set_waiting(cl, 0);
                closure_sub(cl, CLOSURE_WAITING + 1);
        }