asus-wmi: signedness bug in read_brightness()
authorDan Carpenter <error27@gmail.com>
Tue, 15 Mar 2011 07:06:23 +0000 (10:06 +0300)
committerMatthew Garrett <mjg@redhat.com>
Mon, 28 Mar 2011 10:46:06 +0000 (06:46 -0400)
"err" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/asus-wmi.c

index 5b779a9443d6ef0fab8eb6529a3bebbeb5a6b25b..a038595200ee461581558e2149f85a7020917c46 100644 (file)
@@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus)
 static int read_brightness(struct backlight_device *bd)
 {
        struct asus_wmi *asus = bl_get_data(bd);
-       u32 retval, err;
+       u32 retval;
+       int err;
 
        err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);