Driver Core: don't oops with unregistered driver in driver_find_device()
authorHiroshi DOYU <hdoyu@nvidia.com>
Fri, 11 May 2012 08:03:09 +0000 (11:03 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 May 2012 15:46:01 +0000 (08:46 -0700)
driver_find_device() can be called with an unregistered driver. Need
to check driver_private to see if it's populated or not, especially
under deferrable probe.

In the case that there are 2 drivers, one depends on the other. With
-EPROBE_DEFER, two drivers can use deferred probe to ensure that their
relative probe order doesn't matter. If dependee driver is probed
first, then the dependant's driver_find_device('dependee')
succeeds. If the dependant is probed first, then the dependant's
driver_find_device('dependee') should return NULL, and the dependant
should get -EPROBE_DEFER. driver_find_device() needs to return NULL if
it's not populated.

In [PATCHv5 2/3] ARM: tegra: Add SMMU enabler in AHB:
  http://article.gmane.org/gmane.linux.ports.tegra/4658

"tegra_ahb_driver" may not be populated when it's called.

For more SMMU/AHB specific discussion, refer to the following thread:
  https://lkml.org/lkml/2012/5/10/21

Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/driver.c

index 3ec3896c83a659ac069a4d27a98f0bcdd193f78e..207c27ddf828392ef2ffb74ace6d0b4c8269282a 100644 (file)
@@ -80,7 +80,7 @@ struct device *driver_find_device(struct device_driver *drv,
        struct klist_iter i;
        struct device *dev;
 
-       if (!drv)
+       if (!drv || !drv->p)
                return NULL;
 
        klist_iter_init_node(&drv->p->klist_devices, &i,