x86/mcheck: Move threshold_create_device()

Move the threshold_create_device() so it can use
threshold_remove_device() without a forward declaration.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: rt@linutronix.de
Cc: linux-edac@vger.kernel.org
Link: http://lkml.kernel.org/r/20161110174447.11848-2-bigeasy@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c
index 9b540346293624985651ddd795f367bd4810849e..75a3e3eab81e71e5aa37b3505e5ff46f53887144 100644 (file)
--- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
@@ -1010,31 +1010,6 @@ static int threshold_create_bank(unsigned int cpu, unsigned int bank)
        return err;
 }
 
-/* create dir/files for all valid threshold banks */
-static int threshold_create_device(unsigned int cpu)
-{
-       unsigned int bank;
-       struct threshold_bank **bp;
-       int err = 0;
-
-       bp = kzalloc(sizeof(struct threshold_bank *) * mca_cfg.banks,
-                    GFP_KERNEL);
-       if (!bp)
-               return -ENOMEM;
-
-       per_cpu(threshold_banks, cpu) = bp;
-
-       for (bank = 0; bank < mca_cfg.banks; ++bank) {
-               if (!(per_cpu(bank_map, cpu) & (1 << bank)))
-                       continue;
-               err = threshold_create_bank(cpu, bank);
-               if (err)
-                       return err;
-       }
-
-       return err;
-}
-
 static void deallocate_threshold_block(unsigned int cpu,
                                                 unsigned int bank)
 {
@@ -1114,6 +1089,31 @@ static void threshold_remove_device(unsigned int cpu)
        kfree(per_cpu(threshold_banks, cpu));
 }
 
+/* create dir/files for all valid threshold banks */
+static int threshold_create_device(unsigned int cpu)
+{
+       unsigned int bank;
+       struct threshold_bank **bp;
+       int err = 0;
+
+       bp = kzalloc(sizeof(struct threshold_bank *) * mca_cfg.banks,
+                    GFP_KERNEL);
+       if (!bp)
+               return -ENOMEM;
+
+       per_cpu(threshold_banks, cpu) = bp;
+
+       for (bank = 0; bank < mca_cfg.banks; ++bank) {
+               if (!(per_cpu(bank_map, cpu) & (1 << bank)))
+                       continue;
+               err = threshold_create_bank(cpu, bank);
+               if (err)
+                       return err;
+       }
+
+       return err;
+}
+
 /* get notified when a cpu comes on/off */
 static void
 amd_64_threshold_cpu_callback(unsigned long action, unsigned int cpu)