iommu/s390: Use iommu_group_get_for_dev() in s390_iommu_add_device()

The iommu_group_get_for_dev() function also attaches the
device to its group, so this code doesn't need to be in the
iommu driver.

Further by using this function the driver can make use of
default domains in the future.

Reviewed-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
index 179e636a4d916a35e564ed516e7c47af82a1bd83..8788640756a7361ccb656269efd2b8bbb9ac68f7 100644 (file)
--- a/drivers/iommu/s390-iommu.c
+++ b/drivers/iommu/s390-iommu.c
@@ -165,20 +165,14 @@ static void s390_iommu_detach_device(struct iommu_domain *domain,
 
 static int s390_iommu_add_device(struct device *dev)
 {
-       struct iommu_group *group;
-       int rc;
+       struct iommu_group *group = iommu_group_get_for_dev(dev);
 
-       group = iommu_group_get(dev);
-       if (!group) {
-               group = iommu_group_alloc();
-               if (IS_ERR(group))
-                       return PTR_ERR(group);
-       }
+       if (IS_ERR(group))
+               return PTR_ERR(group);
 
-       rc = iommu_group_add_device(group, dev);
        iommu_group_put(group);
 
-       return rc;
+       return 0;
 }
 
 static void s390_iommu_remove_device(struct device *dev)
@@ -344,6 +338,7 @@ static struct iommu_ops s390_iommu_ops = {
        .iova_to_phys = s390_iommu_iova_to_phys,
        .add_device = s390_iommu_add_device,
        .remove_device = s390_iommu_remove_device,
+       .device_group = generic_device_group,
        .pgsize_bitmap = S390_IOMMU_PGSIZES,
 };