sony-laptop: use platform_device_unregister in sony_pf_remove
authorAxel Lin <axel.lin@gmail.com>
Thu, 1 Jul 2010 02:18:01 +0000 (10:18 +0800)
committerMatthew Garrett <mjg@redhat.com>
Tue, 3 Aug 2010 13:48:53 +0000 (09:48 -0400)
platform_device_unregister calls platform_device_del and platform_device_put,
thus this change is logically equivalent to original code.

I made this change because the documents in platform.c shows that:
platform_device_del and platform_device_put must _only_ be externally called
in error cases.  All other usage is a bug.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/sony-laptop.c

index a47fd4eef8a30907fe3a5909d67ecd59b248dee2..e3154ff7a39febe1c5021352f431f2d5fa243064 100644 (file)
@@ -561,8 +561,7 @@ static void sony_pf_remove(void)
        if (!atomic_dec_and_test(&sony_pf_users))
                return;
 
-       platform_device_del(sony_pf_device);
-       platform_device_put(sony_pf_device);
+       platform_device_unregister(sony_pf_device);
        platform_driver_unregister(&sony_pf_driver);
 }