ASoC: sunxi: Remove useless comments and variable
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Tue, 1 Dec 2015 11:06:46 +0000 (12:06 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 1 Dec 2015 15:41:29 +0000 (15:41 +0000)
The comment is misleading on how we should support external power amps, and
the variable is not used and generates a warning.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun4i-codec.c

index 30c9e9260491cce68f060efd788ea8c0c4b8358f..516c7c2b479a0c1f6643ac65cb3e48f97bdb1c8e 100644 (file)
@@ -109,11 +109,6 @@ struct sun4i_codec {
 
 static void sun4i_codec_start_playback(struct sun4i_codec *scodec)
 {
-       /*
-        * FIXME: according to the BSP, we might need to drive a PA
-        *        GPIO high here on some boards
-        */
-
        /* Flush TX FIFO */
        regmap_update_bits(scodec->regmap, SUN4I_CODEC_DAC_FIFOC,
                           BIT(SUN4I_CODEC_DAC_FIFOC_FIFO_FLUSH),
@@ -127,11 +122,6 @@ static void sun4i_codec_start_playback(struct sun4i_codec *scodec)
 
 static void sun4i_codec_stop_playback(struct sun4i_codec *scodec)
 {
-       /*
-        * FIXME: according to the BSP, we might need to drive a PA
-        *        GPIO low here on some boards
-        */
-
        /* Disable DAC DRQ */
        regmap_update_bits(scodec->regmap, SUN4I_CODEC_DAC_FIFOC,
                           BIT(SUN4I_CODEC_DAC_FIFOC_DAC_DRQ_EN),
@@ -140,11 +130,6 @@ static void sun4i_codec_stop_playback(struct sun4i_codec *scodec)
 
 static void sun4i_codec_start_capture(struct sun4i_codec *scodec)
 {
-       /*
-        * FIXME: according to the BSP, we might need to drive a PA
-        *        GPIO high here on some boards
-        */
-
        /* Enable ADC DRQ */
        regmap_update_bits(scodec->regmap, SUN4I_CODEC_ADC_FIFOC,
                           BIT(SUN4I_CODEC_ADC_FIFOC_ADC_DRQ_EN),
@@ -153,11 +138,6 @@ static void sun4i_codec_start_capture(struct sun4i_codec *scodec)
 
 static void sun4i_codec_stop_capture(struct sun4i_codec *scodec)
 {
-       /*
-        * FIXME: according to the BSP, we might need to drive a PA
-        *        GPIO low here on some boards
-        */
-
        /* Disable ADC DRQ */
        regmap_update_bits(scodec->regmap, SUN4I_CODEC_ADC_FIFOC,
                           BIT(SUN4I_CODEC_ADC_FIFOC_ADC_DRQ_EN), 0);
@@ -358,8 +338,6 @@ static int sun4i_codec_hw_params_capture(struct sun4i_codec *scodec,
                                         struct snd_pcm_hw_params *params,
                                         unsigned int hwrate)
 {
-       u32 val;
-
        /* Set ADC sample rate */
        regmap_update_bits(scodec->regmap, SUN4I_CODEC_ADC_FIFOC,
                           7 << SUN4I_CODEC_ADC_FIFOC_ADC_FS,