Relax check on adding children of suspended devices
authorRafael J. Wysocki <rjw@sisk.pl>
Tue, 22 Apr 2008 22:48:23 +0000 (00:48 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 23 Apr 2008 00:19:11 +0000 (17:19 -0700)
Do not refuse to actually register children of suspended devices,
but still warn about attempts to do that.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/base/power/main.c

index c4568b82875b9fb6379f3c650175143c2ebc6e81..7b76fd3b93a41b41b00b0fdac9915ed2bae15ad5 100644 (file)
@@ -62,7 +62,7 @@ static bool all_sleeping;
  */
 int device_pm_add(struct device *dev)
 {
-       int error = 0;
+       int error;
 
        pr_debug("PM: Adding info for %s:%s\n",
                 dev->bus ? dev->bus->name : "No Bus",
@@ -70,18 +70,15 @@ int device_pm_add(struct device *dev)
        mutex_lock(&dpm_list_mtx);
        if ((dev->parent && dev->parent->power.sleeping) || all_sleeping) {
                if (dev->parent->power.sleeping)
-                       dev_warn(dev,
-                               "parent %s is sleeping, will not add\n",
+                       dev_warn(dev, "parent %s is sleeping\n",
                                dev->parent->bus_id);
                else
-                       dev_warn(dev, "devices are sleeping, will not add\n");
+                       dev_warn(dev, "all devices are sleeping\n");
                WARN_ON(true);
-               error = -EBUSY;
-       } else {
-               error = dpm_sysfs_add(dev);
-               if (!error)
-                       list_add_tail(&dev->power.entry, &dpm_active);
        }
+       error = dpm_sysfs_add(dev);
+       if (!error)
+               list_add_tail(&dev->power.entry, &dpm_active);
        mutex_unlock(&dpm_list_mtx);
        return error;
 }