ftrace: add UNINTERRUPTIBLE state for kftraced on disable
authorSteven Rostedt <srostedt@redhat.com>
Mon, 12 May 2008 19:20:55 +0000 (21:20 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 23 May 2008 19:15:42 +0000 (21:15 +0200)
When dynamic ftrace fails and sets itself disabled, the ftraced daemon
will go back to sleep everytime it wakes up. The setting of the
ftraced state to UNINTERRUPTIBLE is skipped in this process, and the
daemon takes up 100% of the CPU.  This patch makes sure the ftraced daemon
sets itself to UNINTERRUPTIBLE in that loop.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/trace/ftrace.c

index 281d97a3208ce70f8ededf70f8186b48586bbddc..40f64f7cd850aaf2d560a97f2f133ec927d0a01d 100644 (file)
@@ -630,10 +630,10 @@ static int ftraced(void *ignore)
 {
        unsigned long usecs;
 
-       set_current_state(TASK_INTERRUPTIBLE);
-
        while (!kthread_should_stop()) {
 
+               set_current_state(TASK_INTERRUPTIBLE);
+
                /* check once a second */
                schedule_timeout(HZ);
 
@@ -667,8 +667,6 @@ static int ftraced(void *ignore)
                wake_up_interruptible(&ftraced_waiters);
 
                ftrace_shutdown_replenish();
-
-               set_current_state(TASK_INTERRUPTIBLE);
        }
        __set_current_state(TASK_RUNNING);
        return 0;