ata: sata_dwc_460ex: don't call ata_sff_qc_issue() on DMA commands

ata_sff_qc_issue() can't handle DMA commands and thus we have to avoid it for
them. Do call ata_bmdma_qc_issue() instead for this case. Note that the former
one distinguishes PIO and DMA mode and behaves accordingly.

Suggested-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 038e5fbf992142ec657612311b91c1ad5bd5766c..f1a4d498ad2d31c96527b2dee458971cb73949a9 100644 (file)
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1061,10 +1061,10 @@ static unsigned int sata_dwc_qc_issue(struct ata_queued_cmd *qc)
                        __func__, tag, qc->ap->link.sactive, sactive);
 
                ap->ops->sff_tf_load(ap, &qc->tf);
-               sata_dwc_exec_command_by_tag(ap, &qc->tf, qc->tag,
+               sata_dwc_exec_command_by_tag(ap, &qc->tf, tag,
                                             SATA_DWC_CMD_ISSUED_PEND);
        } else {
-               ata_sff_qc_issue(qc);
+               return ata_bmdma_qc_issue(qc);
        }
        return 0;
 }