projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 19aab56)
usb: musb: gadget: kill duplicate code in musb_gadget_queue()
authorSergei Shtylyov <sshtylyov@ru.mvista.com>
Fri, 24 Sep 2010 10:44:11 +0000 (13:44 +0300)
committerFelipe Balbi <balbi@ti.com>
Mon, 8 Nov 2010 07:29:55 +0000 (09:29 +0200)
musb_gadget_queue() checks for '!req->buf' condition twice:
in the second case the code is both duplicated and unreachable
as the first check returns early.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/musb/musb_gadget.c patch | blob | blame | history

diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index f37b8594edebbdeb31f786f40bbd4bdf4f903f84..36cfd060dbe55bffb7707293f3c1182ed7cbff6e 100644 (file)
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1169,8 +1169,6 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req,
                                                : DMA_FROM_DEVICE);
                        request->mapped = 0;
                }
-       } else if (!req->buf) {
-               return -ENODATA;
        } else
                request->mapped = 0;