Remove the explicit `solid` flag for icons that don‘t require it

diff --git a/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts b/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts
index b6102c3f9c2537bf8b44069781d17ab18e59823f..c18519abc514a309f37180c032156ecc27153aee 100644 (file)
--- a/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts
+++ b/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts
@@ -58,7 +58,7 @@ export class AcpUiDataImportManager implements AjaxCallbackObject {
     const content = UiDialog.getDialog(this)!.content;
     content.querySelector("h1")!.textContent = Language.get("wcf.acp.dataImport.completed");
     const spinner = content.querySelector("fa-icon")!;
-    spinner.setIcon("check", true);
+    spinner.setIcon("check");
 
     const formSubmit = document.createElement("div");
     formSubmit.className = "formSubmit";

diff --git a/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts b/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts
index 10a28b1990f2f657d08fa5144eed700eb5c4bce4..c0d4ac00342f9ead0fc72e5b692a2b5d67148b87 100644 (file)
--- a/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts
+++ b/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts
@@ -108,7 +108,7 @@ class AcpUiWorker implements AjaxCallbackObject, DialogCallbackObject {
       });
 
       const spinner = content.querySelector("fa-icon")!;
-      spinner.setIcon("check", true);
+      spinner.setIcon("check");
       spinner.parentElement!.dataset.status = "success";
 
       const formSubmit = document.createElement("div");
@@ -151,7 +151,7 @@ class AcpUiWorker implements AjaxCallbackObject, DialogCallbackObject {
     const dialog = UiDialog.getDialog(this);
     if (dialog !== undefined) {
       const spinner = dialog.content.querySelector("fa-icon")!;
-      spinner.setIcon("xmark", true);
+      spinner.setIcon("xmark");
       spinner.parentElement!.dataset.status = "error";
     }
 

diff --git a/ts/WoltLabSuite/Core/Ajax/Status.ts b/ts/WoltLabSuite/Core/Ajax/Status.ts
index 80542deb57aca4566278f6b2d0406e759a5e5ff6..edc77dd351f2b008298554f9f3d9b1deb574cae8 100644 (file)
--- a/ts/WoltLabSuite/Core/Ajax/Status.ts
+++ b/ts/WoltLabSuite/Core/Ajax/Status.ts
@@ -21,7 +21,7 @@ class AjaxStatus {
 
     const icon = document.createElement("fa-icon");
     icon.size = 48;
-    icon.setIcon("spinner", true);
+    icon.setIcon("spinner");
     this._overlay.appendChild(icon);
 
     const title = document.createElement("span");

diff --git a/ts/WoltLabSuite/Core/Bbcode/Collapsible.ts b/ts/WoltLabSuite/Core/Bbcode/Collapsible.ts
index 7a9d03d2cdd1955c8a648ccfa45d05f1379b733e..d80cbea813758559741084033bfd369672b8cafa 100644 (file)
--- a/ts/WoltLabSuite/Core/Bbcode/Collapsible.ts
+++ b/ts/WoltLabSuite/Core/Bbcode/Collapsible.ts
@@ -40,7 +40,7 @@ function toggleContainer(container: HTMLElement, toggleButtons: HTMLElement[], e
       const title = toggleButton.dataset.titleExpand!;
       const icon = toggleButton.querySelector("fa-icon");
       if (icon) {
-        icon.setIcon("up-right-and-down-left-from-center", true);
+        icon.setIcon("up-right-and-down-left-from-center");
         toggleButton.title = title;
       } else {
         toggleButton.textContent = title;
@@ -64,7 +64,7 @@ function toggleContainer(container: HTMLElement, toggleButtons: HTMLElement[], e
       const title = toggleButton.dataset.titleCollapse!;
       const icon = toggleButton.querySelector("fa-icon");
       if (icon) {
-        icon.setIcon("down-left-and-up-right-to-center", true);
+        icon.setIcon("down-left-and-up-right-to-center");
         toggleButton.title = title;
       } else {
         toggleButton.textContent = title;

diff --git a/ts/WoltLabSuite/Core/Controller/User/Notification/Settings.ts b/ts/WoltLabSuite/Core/Controller/User/Notification/Settings.ts
index cf3c4f08ef541b90ab42e240e0e79235177d8705..a91e077a3d20dfa54763f223ba48a39fb74b0908 100644 (file)
--- a/ts/WoltLabSuite/Core/Controller/User/Notification/Settings.ts
+++ b/ts/WoltLabSuite/Core/Controller/User/Notification/Settings.ts
@@ -100,15 +100,15 @@ function setEmailType(event: Event): void {
   const icon = button.querySelector(".jsIconNotificationSettingsEmailType fa-icon") as FaIcon;
   switch (value) {
     case "daily":
-      icon.setIcon("clock", false);
+      icon.setIcon("clock");
       break;
 
     case "instant":
-      icon.setIcon("bolt", true);
+      icon.setIcon("bolt");
       break;
 
     case "none":
-      icon.setIcon("xmark", true);
+      icon.setIcon("xmark");
       break;
   }
 

diff --git a/ts/WoltLabSuite/Core/Media/Upload.ts b/ts/WoltLabSuite/Core/Media/Upload.ts
index 30341baace6fea896ebe649fd4b6c048799fdea3..267200a0d58019dc4a5b4fa8807f68d51f45b4b1 100644 (file)
--- a/ts/WoltLabSuite/Core/Media/Upload.ts
+++ b/ts/WoltLabSuite/Core/Media/Upload.ts
@@ -241,7 +241,7 @@ class MediaUpload<TOptions extends MediaUploadOptions = MediaUploadOptions> exte
           });
 
           const fileIcon = file.querySelector("fa-icon")!;
-          fileIcon.setIcon("xmark", true);
+          fileIcon.setIcon("xmark");
           fileIcon.insertAdjacentElement("beforebegin", deleteButton);
           deleteButton.append(fileIcon);
 
@@ -282,7 +282,7 @@ class MediaUpload<TOptions extends MediaUploadOptions = MediaUploadOptions> exte
           }
 
           const fileIcon = DomTraverse.childByTag(DomTraverse.childByClass(file, "mediaThumbnail")!, "FA-ICON")!;
-          fileIcon.setIcon("xmark", true);
+          fileIcon.setIcon("xmark");
 
           file.classList.add("uploadFailed", "pointer", "jsTooltip");
           file.title = Language.get("wcf.global.button.delete");

diff --git a/ts/WoltLabSuite/Core/Ui/File/Upload.ts b/ts/WoltLabSuite/Core/Ui/File/Upload.ts
index 09540f68d6f94a64e2eef0d306e28f71770cabb0..1dc1a8290db6eff171da5e5d0d1e5353f53e671c 100644 (file)
--- a/ts/WoltLabSuite/Core/Ui/File/Upload.ts
+++ b/ts/WoltLabSuite/Core/Ui/File/Upload.ts
@@ -87,7 +87,7 @@ class FileUpload extends Upload<FileUploadOptions> implements FileUploadHandler
 
     const icon = document.createElement("fa-icon");
     icon.size = 64;
-    icon.setIcon("spinner", false);
+    icon.setIcon("spinner");
 
     const fileName = element.textContent;
     element.textContent = "";
@@ -124,7 +124,7 @@ class FileUpload extends Upload<FileUploadOptions> implements FileUploadHandler
       small.innerHTML = "";
 
       const icon = fileElement.querySelector("fa-icon")!;
-      icon.setIcon("ban", true);
+      icon.setIcon("ban");
 
       const innerError = document.createElement("span");
       innerError.className = "innerError";
@@ -200,7 +200,7 @@ class FileUpload extends Upload<FileUploadOptions> implements FileUploadHandler
         small.innerHTML = "";
 
         const icon = fileElement.querySelector("fa-icon")!;
-        icon.setIcon("ban", true);
+        icon.setIcon("ban");
 
         let innerError = fileElement.querySelector(".innerError") as HTMLElement;
         if (innerError === null) {

diff --git a/ts/WoltLabSuite/Core/Ui/ItemList/Filter.ts b/ts/WoltLabSuite/Core/Ui/ItemList/Filter.ts
index 445eb2847253619bd58444b060083583a6e92e16..f1a910fa1ded0bf0eee5ea61fb3e1af04abe6e1f 100644 (file)
--- a/ts/WoltLabSuite/Core/Ui/ItemList/Filter.ts
+++ b/ts/WoltLabSuite/Core/Ui/ItemList/Filter.ts
@@ -368,9 +368,9 @@ class UiItemListFilter {
 
     const icon = button.querySelector("fa-icon")!;
     if (type === "showAll") {
-      icon.setIcon("eye", false);
+      icon.setIcon("eye");
     } else {
-      icon.setIcon("eye-slash", false);
+      icon.setIcon("eye-slash");
     }
   }
 }

diff --git a/ts/WoltLabSuite/Core/Ui/Object/Action/Toggle.ts b/ts/WoltLabSuite/Core/Ui/Object/Action/Toggle.ts
index 07834df2afbbc4eb5364ccc6830bd66bbee2600d..4fda91f0d293058ed4af993dc1c2c0f6ea8b7800 100644 (file)
--- a/ts/WoltLabSuite/Core/Ui/Object/Action/Toggle.ts
+++ b/ts/WoltLabSuite/Core/Ui/Object/Action/Toggle.ts
@@ -21,12 +21,12 @@ function toggleObject(data: ObjectActionData): void {
     actionElement.nodeName === "FA-ICON" ? (actionElement as FaIcon) : actionElement.querySelector("fa-icon");
   if (icon) {
     if (icon.name === "square") {
-      icon.setIcon("square-check", false);
+      icon.setIcon("square-check");
 
       const newTitle = actionElement.dataset.disableTitle || Language.get("wcf.global.button.disable");
       actionElement.title = newTitle;
     } else {
-      icon.setIcon("square", false);
+      icon.setIcon("square");
 
       const newTitle = actionElement.dataset.enableTitle || Language.get("wcf.global.button.enable");
       actionElement.title = newTitle;

diff --git a/ts/WoltLabSuite/Core/Ui/Password.ts b/ts/WoltLabSuite/Core/Ui/Password.ts
index ea47d2659acc1d7eabe59a8eff0fc4aeb11590c0..150d4190cd63449d7fccafb8b289a13a1a4e7612 100644 (file)
--- a/ts/WoltLabSuite/Core/Ui/Password.ts
+++ b/ts/WoltLabSuite/Core/Ui/Password.ts
@@ -43,7 +43,7 @@ function initElement(input: HTMLInputElement): void {
 
   const icon = document.createElement("fa-icon");
   icon.size = 16;
-  icon.setIcon("eye", false);
+  icon.setIcon("eye");
   button.appendChild(icon);
 
   button.addEventListener("click", () => {
@@ -66,11 +66,11 @@ function initElement(input: HTMLInputElement): void {
 
 function toggle(input: HTMLInputElement, button: HTMLElement, icon: FaIcon): void {
   if (input.type === "password") {
-    icon.setIcon("eye-slash", false);
+    icon.setIcon("eye-slash");
     button.dataset.tooltip = Language.get("wcf.global.form.password.button.hide");
     input.type = "text";
   } else {
-    icon.setIcon("eye-slash", true);
+    icon.setIcon("eye-slash");
     button.dataset.tooltip = Language.get("wcf.global.form.password.button.show");
     input.type = "password";
   }

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.js
index d1639e3a8820c943143c112988b69a94fc73c69e..037a1a3db66e21d2877b64c4cd53260ed0291a19 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.js
@@ -43,7 +43,7 @@ define(["require", "exports", "tslib", "../../../Ajax", "../../../Core", "../../
             const content = Dialog_1.default.getDialog(this).content;
             content.querySelector("h1").textContent = Language.get("wcf.acp.dataImport.completed");
             const spinner = content.querySelector("fa-icon");
-            spinner.setIcon("check", true);
+            spinner.setIcon("check");
             const formSubmit = document.createElement("div");
             formSubmit.className = "formSubmit";
             formSubmit.innerHTML = `<button class="button buttonPrimary">${Language.get("wcf.global.button.next")}</button>`;

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Worker.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Worker.js
index d872158b195510a72996ded5116f3d2d20ac014d..4053b00ab5c832822c3db30caded975f69197004 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Worker.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Worker.js
@@ -63,7 +63,7 @@ define(["require", "exports", "tslib", "../../Ajax", "../../Core", "../../Langua
                     Dialog_1.default.setCallback(this, "onClose", () => this.onClose());
                 });
                 const spinner = content.querySelector("fa-icon");
-                spinner.setIcon("check", true);
+                spinner.setIcon("check");
                 spinner.parentElement.dataset.status = "success";
                 const formSubmit = document.createElement("div");
                 formSubmit.className = "formSubmit";
@@ -100,7 +100,7 @@ define(["require", "exports", "tslib", "../../Ajax", "../../Core", "../../Langua
             const dialog = Dialog_1.default.getDialog(this);
             if (dialog !== undefined) {
                 const spinner = dialog.content.querySelector("fa-icon");
-                spinner.setIcon("xmark", true);
+                spinner.setIcon("xmark");
                 spinner.parentElement.dataset.status = "error";
             }
             return true;

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ajax/Status.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ajax/Status.js
index 2cab0c4255a6618ded56ea00ee5cd61f8e2ffecd..a9eb2936fe1d0923fcdd6cc247054d56ec732b8d 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ajax/Status.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ajax/Status.js
@@ -20,7 +20,7 @@ define(["require", "exports", "tslib", "../Language"], function (require, export
             this._overlay.setAttribute("role", "status");
             const icon = document.createElement("fa-icon");
             icon.size = 48;
-            icon.setIcon("spinner", true);
+            icon.setIcon("spinner");
             this._overlay.appendChild(icon);
             const title = document.createElement("span");
             title.textContent = Language.get("wcf.global.loading");

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Bbcode/Collapsible.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Bbcode/Collapsible.js
index 3e39b1dc6dadf9c2e3e5957fcf3621cb8821d350..f7a3a24870f90d3b99e4fadd292c48ff7444d37b 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Bbcode/Collapsible.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Bbcode/Collapsible.js
@@ -39,7 +39,7 @@ define(["require", "exports"], function (require, exports) {
                 const title = toggleButton.dataset.titleExpand;
                 const icon = toggleButton.querySelector("fa-icon");
                 if (icon) {
-                    icon.setIcon("up-right-and-down-left-from-center", true);
+                    icon.setIcon("up-right-and-down-left-from-center");
                     toggleButton.title = title;
                 }
                 else {
@@ -63,7 +63,7 @@ define(["require", "exports"], function (require, exports) {
                 const title = toggleButton.dataset.titleCollapse;
                 const icon = toggleButton.querySelector("fa-icon");
                 if (icon) {
-                    icon.setIcon("down-left-and-up-right-to-center", true);
+                    icon.setIcon("down-left-and-up-right-to-center");
                     toggleButton.title = title;
                 }
                 else {

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Controller/User/Notification/Settings.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Controller/User/Notification/Settings.js
index 0696d6c609d3827124081dfb99012eb6e4046149..19ad1b23abd1fd2c91c1ba5c35d44e06ff3b5df2 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Controller/User/Notification/Settings.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Controller/User/Notification/Settings.js
@@ -84,13 +84,13 @@ define(["require", "exports", "tslib", "../../../Language", "../../../Ui/Dropdow
         const icon = button.querySelector(".jsIconNotificationSettingsEmailType fa-icon");
         switch (value) {
             case "daily":
-                icon.setIcon("clock", false);
+                icon.setIcon("clock");
                 break;
             case "instant":
-                icon.setIcon("bolt", true);
+                icon.setIcon("bolt");
                 break;
             case "none":
-                icon.setIcon("xmark", true);
+                icon.setIcon("xmark");
                 break;
         }
         _objectId = 0;

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Media/Upload.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Media/Upload.js
index 65e796117bef3d3a1dfe585c6bfb2c9a3d7cb0e8..d53f529b07349d1649f76b08f4449f2b4e78c19b 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Media/Upload.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Media/Upload.js
@@ -199,7 +199,7 @@ define(["require", "exports", "tslib", "../Upload", "../Core", "../Dom/Util", ".
                             EventHandler.fire("com.woltlab.wcf.media.upload", "removedErroneousUploadRow");
                         });
                         const fileIcon = file.querySelector("fa-icon");
-                        fileIcon.setIcon("xmark", true);
+                        fileIcon.setIcon("xmark");
                         fileIcon.insertAdjacentElement("beforebegin", deleteButton);
                         deleteButton.append(fileIcon);
                         file.classList.add("uploadFailed");
@@ -231,7 +231,7 @@ define(["require", "exports", "tslib", "../Upload", "../Core", "../Dom/Util", ".
                             };
                         }
                         const fileIcon = DomTraverse.childByTag(DomTraverse.childByClass(file, "mediaThumbnail"), "FA-ICON");
-                        fileIcon.setIcon("xmark", true);
+                        fileIcon.setIcon("xmark");
                         file.classList.add("uploadFailed", "pointer", "jsTooltip");
                         file.title = Language.get("wcf.global.button.delete");
                         file.addEventListener("click", () => file.remove());

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Upload.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Upload.js
index 34871c0ea337b61493bdba67460e178ef8c95f1f..e56fab66ba838d1d67b8d86f170d5eb099238828 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Upload.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Upload.js
@@ -43,7 +43,7 @@ define(["require", "exports", "tslib", "../../Core", "./Delete", "../../Dom/Util
             const progress = element.querySelector("progress");
             const icon = document.createElement("fa-icon");
             icon.size = 64;
-            icon.setIcon("spinner", false);
+            icon.setIcon("spinner");
             const fileName = element.textContent;
             element.textContent = "";
             element.append(icon);
@@ -69,7 +69,7 @@ define(["require", "exports", "tslib", "../../Core", "./Delete", "../../Dom/Util
                 const small = fileElement.querySelector("small");
                 small.innerHTML = "";
                 const icon = fileElement.querySelector("fa-icon");
-                icon.setIcon("ban", true);
+                icon.setIcon("ban");
                 const innerError = document.createElement("span");
                 innerError.className = "innerError";
                 innerError.textContent = Language.get("wcf.upload.error.uploadFailed");
@@ -134,7 +134,7 @@ define(["require", "exports", "tslib", "../../Core", "./Delete", "../../Dom/Util
                     const small = fileElement.querySelector("small");
                     small.innerHTML = "";
                     const icon = fileElement.querySelector("fa-icon");
-                    icon.setIcon("ban", true);
+                    icon.setIcon("ban");
                     let innerError = fileElement.querySelector(".innerError");
                     if (innerError === null) {
                         innerError = document.createElement("span");

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList/Filter.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList/Filter.js
index 8f6392d92dd9afd1b2b80e96344de9b44afe212e..491503f9bb71e893bbfe60e2ea58a1e6645e9283 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList/Filter.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList/Filter.js
@@ -295,10 +295,10 @@ define(["require", "exports", "tslib", "../../Core", "../../Dom/Util", "../../La
             }
             const icon = button.querySelector("fa-icon");
             if (type === "showAll") {
-                icon.setIcon("eye", false);
+                icon.setIcon("eye");
             }
             else {
-                icon.setIcon("eye-slash", false);
+                icon.setIcon("eye-slash");
             }
         }
     }

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Object/Action/Toggle.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Object/Action/Toggle.js
index e436e411e6035f841f7318f58e72857dabac2c0b..716a31f8aee619b06469f3d1218178fce59771df 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Object/Action/Toggle.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Object/Action/Toggle.js
@@ -20,12 +20,12 @@ define(["require", "exports", "tslib", "../../../Language", "./Handler"], functi
         const icon = actionElement.nodeName === "FA-ICON" ? actionElement : actionElement.querySelector("fa-icon");
         if (icon) {
             if (icon.name === "square") {
-                icon.setIcon("square-check", false);
+                icon.setIcon("square-check");
                 const newTitle = actionElement.dataset.disableTitle || Language.get("wcf.global.button.disable");
                 actionElement.title = newTitle;
             }
             else {
-                icon.setIcon("square", false);
+                icon.setIcon("square");
                 const newTitle = actionElement.dataset.enableTitle || Language.get("wcf.global.button.enable");
                 actionElement.title = newTitle;
             }

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Password.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Password.js
index 3e87d79f54b7603d78035ab3458b50264d2127c0..9e01eca2ce4212ee115edfb347ae6cd38357bcb7 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Password.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Password.js
@@ -40,7 +40,7 @@ define(["require", "exports", "tslib", "../Dom/Change/Listener", "../Language"],
         inputAddon.appendChild(button);
         const icon = document.createElement("fa-icon");
         icon.size = 16;
-        icon.setIcon("eye", false);
+        icon.setIcon("eye");
         button.appendChild(icon);
         button.addEventListener("click", () => {
             toggle(input, button, icon);
@@ -59,12 +59,12 @@ define(["require", "exports", "tslib", "../Dom/Change/Listener", "../Language"],
     }
     function toggle(input, button, icon) {
         if (input.type === "password") {
-            icon.setIcon("eye-slash", false);
+            icon.setIcon("eye-slash");
             button.dataset.tooltip = Language.get("wcf.global.form.password.button.hide");
             input.type = "text";
         }
         else {
-            icon.setIcon("eye-slash", true);
+            icon.setIcon("eye-slash");
             button.dataset.tooltip = Language.get("wcf.global.form.password.button.show");
             input.type = "password";
         }