projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: a4292d7)
of: Format string bug in drivers/of/of_i2c.c
authorJon Smirl <jonsmirl@gmail.com>
Mon, 20 Oct 2008 02:13:15 +0000 (02:13 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 21 Oct 2008 04:17:49 +0000 (15:17 +1100)
Format string bug.  Not exploitable, as this is only writable by root,
but worth fixing all the same.

See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
drivers/of/of_i2c.c patch | blob | blame | history

diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index 6a98dc8aa30b1af9a1e8ce9a2a8264073a631eee..24bbef777c1914cfb7096cec8f198fdbc7512618 100644 (file)
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
 
                info.addr = *addr;
 
-               request_module(info.type);
+               request_module("%s", info.type);
 
                result = i2c_new_device(adap, &info);
                if (result == NULL) {