projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 5b28f0f)
video: hgafb: remove unneeded comparison
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 13 Jan 2015 16:14:59 +0000 (21:44 +0530)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Mon, 26 Jan 2015 12:43:06 +0000 (14:43 +0200)
var->yoffset is of the type __u32, hence the comparison will always
be false.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/hgafb.c patch | blob | blame | history

diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index 5ff9fe2116a49bcc4da7838aa30e3589866d54ae..15d3ccff296542b74c6ccab42f5c1c1fac1c986f 100644 (file)
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -417,8 +417,7 @@ static int hgafb_pan_display(struct fb_var_screeninfo *var,
                             struct fb_info *info)
 {
        if (var->vmode & FB_VMODE_YWRAP) {
-               if (var->yoffset < 0 || 
-                   var->yoffset >= info->var.yres_virtual ||
+               if (var->yoffset >= info->var.yres_virtual ||
                    var->xoffset)
                        return -EINVAL;
        } else {