net-next: dsa: fix duplicate invocation of set_addr()
authorJohn Crispin <john@phrozen.org>
Mon, 19 Sep 2016 13:28:00 +0000 (15:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Sep 2016 08:47:44 +0000 (04:47 -0400)
commit 83c0afaec7b730b ("net: dsa: Add new binding implementation")
has a duplicate invocation of the set_addr() operation callback. Remove one
of them.

Signed-off-by: John Crispin <john@phrozen.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/dsa2.c

index 8278385dcd212f9b5292370cfdbcffe92b4a6e05..cffc19e972a117d6b3389299ddcca198c5e7aac6 100644 (file)
@@ -308,10 +308,6 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
        if (err < 0)
                return err;
 
-       err = ds->ops->set_addr(ds, dst->master_netdev->dev_addr);
-       if (err < 0)
-               return err;
-
        if (!ds->slave_mii_bus && ds->ops->phy_read) {
                ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
                if (!ds->slave_mii_bus)