fbdev: sh_mobile_meram: Correct pointer check for YCbCr chroma plane
authorDamian Hobson-Garcia <dhobsong@igel.co.jp>
Wed, 22 Jun 2011 07:46:25 +0000 (07:46 +0000)
committerPaul Mundt <lethal@linux-sh.org>
Fri, 24 Jun 2011 07:40:28 +0000 (16:40 +0900)
The check was intended to test if we have a valid pointer to write into,
but it mistakenly checks the pointer contents instead.

Since a valid pointer is mandatory for the chroma data if a YCbCr format
is used, the pointer check has been removed.

Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
drivers/video/sh_mobile_meram.c

index 9170c82b495ca7a84642b0d8a74a3bc803e45609..cc7d7329dc151af821153feb999998e42460267e 100644 (file)
@@ -218,7 +218,7 @@ static inline void meram_get_next_icb_addr(struct sh_mobile_meram_info *pdata,
                icb_offset = 0xc0000000 | (cfg->current_reg << 23);
 
        *icb_addr_y = icb_offset | (cfg->icb[0].marker_icb << 24);
-       if ((*icb_addr_c) && is_nvcolor(cfg->pixelformat))
+       if (is_nvcolor(cfg->pixelformat))
                *icb_addr_c = icb_offset | (cfg->icb[1].marker_icb << 24);
 }