[IPV6]: The ifa lock is a BH lock
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 9 Aug 2006 23:52:04 +0000 (16:52 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Aug 2006 23:52:04 +0000 (16:52 -0700)
The ifa lock is expected to be taken in BH context (by addrconf timers)
so we must disable BH when accessing it from user context.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c

index 8ea1e36bf8ebbe7b5b9f161272a66cf28c35c3bb..0c5042e7380d391769f8e484132157735cb35e6e 100644 (file)
@@ -1909,11 +1909,11 @@ static int inet6_addr_add(int ifindex, struct in6_addr *pfx, int plen,
        ifp = ipv6_add_addr(idev, pfx, plen, scope, ifa_flags);
 
        if (!IS_ERR(ifp)) {
-               spin_lock(&ifp->lock);
+               spin_lock_bh(&ifp->lock);
                ifp->valid_lft = valid_lft;
                ifp->prefered_lft = prefered_lft;
                ifp->tstamp = jiffies;
-               spin_unlock(&ifp->lock);
+               spin_unlock_bh(&ifp->lock);
 
                addrconf_dad_start(ifp, 0);
                in6_ifa_put(ifp);