proc: just list_del() struct pde_opener
authorAlexey Dobriyan <adobriyan@gmail.com>
Tue, 13 Dec 2016 00:45:14 +0000 (16:45 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 13 Dec 2016 02:55:09 +0000 (18:55 -0800)
list_del_init() is too much, structure will be freed in three lines
anyway.

Link: http://lkml.kernel.org/r/20161029155313.GA1246@avx2
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/inode.c

index e69ebe648a34bd69b1a0242fbdb5bb737edee2e9..907265009b03b56a361a86412e8b59d8076c75bd 100644 (file)
@@ -152,7 +152,7 @@ static void close_pdeo(struct proc_dir_entry *pde, struct pde_opener *pdeo)
                file = pdeo->file;
                pde->proc_fops->release(file_inode(file), file);
                spin_lock(&pde->pde_unload_lock);
-               list_del_init(&pdeo->lh);
+               list_del(&pdeo->lh);
                if (pdeo->c)
                        complete(pdeo->c);
                kfree(pdeo);