X25: remove bkl in routing ioctls
authorandrew hendry <andrew.hendry@gmail.com>
Thu, 18 Nov 2010 13:21:35 +0000 (13:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Nov 2010 20:40:02 +0000 (12:40 -0800)
Routing doesn't use the socket data and is protected by x25_route_list_lock

Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/af_x25.c

index 2f235a6cb3b18f81bc7b1d285305421119986227..2351aceb296d378fc32a94a8e6c3c2d0fb7d76e2 100644 (file)
@@ -1412,9 +1412,7 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
                        rc = -EPERM;
                        if (!capable(CAP_NET_ADMIN))
                                break;
-                       lock_kernel();
                        rc = x25_route_ioctl(cmd, argp);
-                       unlock_kernel();
                        break;
                case SIOCX25GSUBSCRIP:
                        lock_kernel();
@@ -1710,9 +1708,7 @@ static int compat_x25_ioctl(struct socket *sock, unsigned int cmd,
                rc = -EPERM;
                if (!capable(CAP_NET_ADMIN))
                        break;
-               lock_kernel();
                rc = x25_route_ioctl(cmd, argp);
-               unlock_kernel();
                break;
        case SIOCX25GSUBSCRIP:
                lock_kernel();