net: Verify permission to link_net in newlink
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 26 Feb 2015 22:20:07 +0000 (16:20 -0600)
committerDavid S. Miller <davem@davemloft.net>
Sat, 28 Feb 2015 20:14:44 +0000 (15:14 -0500)
When applicable verify that the caller has permisson to the underlying
network namespace for a newly created network device.

Similary checks exist for the network namespace a network device will
be created in.

Fixes: 317f4810e45e ("rtnl: allow to create device with IFLA_LINK_NETNSID set")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c

index b237959c74975037437f1606ab0027d49b183c4d..2c49355d16c2279ab89b76cfb532867e604f5c11 100644 (file)
@@ -2134,6 +2134,9 @@ replay:
                                err =  -EINVAL;
                                goto out;
                        }
+                       err = -EPERM;
+                       if (!netlink_ns_capable(skb, link_net->user_ns, CAP_NET_ADMIN))
+                               goto out;
                }
 
                dev = rtnl_create_link(link_net ? : dest_net, ifname,