mlx5: avoid build warnings on 32-bit
authorArnd Bergmann <arnd@arndb.de>
Tue, 13 Jan 2015 16:08:06 +0000 (17:08 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Jan 2015 22:08:20 +0000 (17:08 -0500)
The mlx5 driver passes a string pointer in through a 'u64' variable,
which on 32-bit machines causes a build warning:

drivers/net/ethernet/mellanox/mlx5/core/debugfs.c: In function 'qp_read_field':
drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:303:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

The code is in fact safe, so we can shut up the warning by adding
extra type casts.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/debugfs.c

index 10e1f1a18255986f4e9c5a42e1fb909a0a869028..4878025e231c6b4ebb9f63c72ec3fcdf1402150b 100644 (file)
@@ -300,11 +300,11 @@ static u64 qp_read_field(struct mlx5_core_dev *dev, struct mlx5_core_qp *qp,
                param = qp->pid;
                break;
        case QP_STATE:
-               param = (u64)mlx5_qp_state_str(be32_to_cpu(ctx->flags) >> 28);
+               param = (unsigned long)mlx5_qp_state_str(be32_to_cpu(ctx->flags) >> 28);
                *is_str = 1;
                break;
        case QP_XPORT:
-               param = (u64)mlx5_qp_type_str((be32_to_cpu(ctx->flags) >> 16) & 0xff);
+               param = (unsigned long)mlx5_qp_type_str((be32_to_cpu(ctx->flags) >> 16) & 0xff);
                *is_str = 1;
                break;
        case QP_MTU:
@@ -464,7 +464,7 @@ static ssize_t dbg_read(struct file *filp, char __user *buf, size_t count,
 
 
        if (is_str)
-               ret = snprintf(tbuf, sizeof(tbuf), "%s\n", (const char *)field);
+               ret = snprintf(tbuf, sizeof(tbuf), "%s\n", (const char *)(unsigned long)field);
        else
                ret = snprintf(tbuf, sizeof(tbuf), "0x%llx\n", field);