mac80211: fix potential NULL dereference
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 27 Nov 2012 17:31:19 +0000 (20:31 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 28 Nov 2012 12:46:22 +0000 (13:46 +0100)
Smatch complains that we could dereference skb later in the function.
It's probably unlikely, but we may as well return here and avoid it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[change summary]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rx.c

index 9b13b8b24245d76a0f925753ae7729269d0ba5d1..db343fa8033cad55cbadbbb4296e3e566b8229e3 100644 (file)
@@ -49,7 +49,7 @@ static struct sk_buff *remove_monitor_info(struct ieee80211_local *local,
                        /* driver bug */
                        WARN_ON(1);
                        dev_kfree_skb(skb);
-                       skb = NULL;
+                       return NULL;
                }
        }