Input: imx_keypad - use the preferred form for passing a size of a struct
authorFabio Estevam <fabio.estevam@freescale.com>
Sun, 4 Jan 2015 22:28:46 +0000 (14:28 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 8 Jan 2015 00:02:52 +0000 (16:02 -0800)
According to Documentation/CodingStyle - Chapter 14:

"The preferred form for passing a size of a struct is the following:

        p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."

So do it as recommended.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/imx_keypad.c

index 20a99c368d16f092aa60df47a481a8931d316100..3b681c8042abed29621b442e5b8e2eb780f2c17b 100644 (file)
@@ -448,8 +448,7 @@ static int imx_keypad_probe(struct platform_device *pdev)
                return -ENOMEM;
        }
 
-       keypad = devm_kzalloc(&pdev->dev, sizeof(struct imx_keypad),
-                             GFP_KERNEL);
+       keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
        if (!keypad) {
                dev_err(&pdev->dev, "not enough memory for driver data\n");
                return -ENOMEM;