JFS: Fix race waking up jfsIO kernel thread
authorDave Kleikamp <shaggy@linux.vnet.ibm.com>
Sat, 5 May 2007 19:24:05 +0000 (14:24 -0500)
committerDave Kleikamp <shaggy@linux.vnet.ibm.com>
Sat, 5 May 2007 19:24:05 +0000 (14:24 -0500)
It's possible for a journal I/O request to be added to the log_redrive
queue and the jfsIO thread to be awakened after the thread releases
log_redrive_lock but before it sets its state to TASK_INTERRUPTIBLE.

The jfsIO thread should set the state before giving up the spinlock, so
the waking thread will really wake it.

Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
fs/jfs/jfs_logmgr.c

index ff7f1beec30d6c03dcceb19ea9258fb18b9d294c..16c62680fcd6fe9cb28bc9d51896364bde4c5526 100644 (file)
@@ -2354,12 +2354,13 @@ int jfsIOWait(void *arg)
                        lbmStartIO(bp);
                        spin_lock_irq(&log_redrive_lock);
                }
-               spin_unlock_irq(&log_redrive_lock);
 
                if (freezing(current)) {
+                       spin_unlock_irq(&log_redrive_lock);
                        refrigerator();
                } else {
                        set_current_state(TASK_INTERRUPTIBLE);
+                       spin_unlock_irq(&log_redrive_lock);
                        schedule();
                        __set_current_state(TASK_RUNNING);
                }