ftrace: Only update the function code on write to filter files
authorSteven Rostedt <srostedt@redhat.com>
Sat, 30 Apr 2011 02:35:33 +0000 (22:35 -0400)
committerSteven Rostedt <rostedt@goodmis.org>
Sat, 30 Apr 2011 02:42:59 +0000 (22:42 -0400)
If function tracing is enabled, a read of the filter files will
cause the call to stop_machine to update the function trace sites.
It should only call stop_machine on write.

Cc: stable@kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/ftrace.c

index ee24fa1935ac7d25ec593ebfe3824f6339c0cea5..666880d051ef3cabac32d0c8ea931016a64b2a10 100644 (file)
@@ -2413,14 +2413,16 @@ ftrace_regex_release(struct inode *inode, struct file *file, int enable)
                ftrace_match_records(parser->buffer, parser->idx, enable);
        }
 
-       mutex_lock(&ftrace_lock);
-       if (ftrace_start_up && ftrace_enabled)
-               ftrace_run_update_code(FTRACE_ENABLE_CALLS);
-       mutex_unlock(&ftrace_lock);
-
        trace_parser_put(parser);
        kfree(iter);
 
+       if (file->f_mode & FMODE_WRITE) {
+               mutex_lock(&ftrace_lock);
+               if (ftrace_start_up && ftrace_enabled)
+                       ftrace_run_update_code(FTRACE_ENABLE_CALLS);
+               mutex_unlock(&ftrace_lock);
+       }
+
        mutex_unlock(&ftrace_regex_lock);
        return 0;
 }