OMAPFB: use devm_kzalloc to allocate omapfb2_device
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 13 Dec 2012 10:08:21 +0000 (12:08 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 13 Dec 2012 10:08:21 +0000 (12:08 +0200)
Use devm_kzalloc to allocate omapfb2_device. This fixes possible memory
leak:

drivers/video/omap2/omapfb/omapfb-main.c:2553 omapfb_probe() warn:
possible memory leak of 'fbdev'

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/omapfb/omapfb-main.c

index 4fa9487a8720bc3d5e14586877a89fc27a7becf0..477a20817d084941197f10adfaf18c0de64e33a4 100644 (file)
@@ -1868,7 +1868,6 @@ static void omapfb_free_resources(struct omapfb2_device *fbdev)
        }
 
        dev_set_drvdata(fbdev->dev, NULL);
-       kfree(fbdev);
 }
 
 static int omapfb_create_framebuffers(struct omapfb2_device *fbdev)
@@ -2413,7 +2412,8 @@ static int __init omapfb_probe(struct platform_device *pdev)
                goto err0;
        }
 
-       fbdev = kzalloc(sizeof(struct omapfb2_device), GFP_KERNEL);
+       fbdev = devm_kzalloc(&pdev->dev, sizeof(struct omapfb2_device),
+                       GFP_KERNEL);
        if (fbdev == NULL) {
                r = -ENOMEM;
                goto err0;