mm: try harder to allocate vmemmap blocks
authorBen Hutchings <ben@decadent.org.uk>
Mon, 29 Apr 2013 22:07:49 +0000 (15:07 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 29 Apr 2013 22:54:35 +0000 (15:54 -0700)
Hot-adding memory on x86_64 normally requires huge page allocation.
When this is done to a VM guest, it's usually because the system is
already tight on memory, so the request tends to fail.  Try to avoid
this by adding __GFP_REPEAT to the allocation flags.

Addresses http://bugs.debian.org/699913

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reported-by: Bernhard Schmidt <Bernhard.Schmidt@lrz.de>
Tested-by: Bernhard Schmidt <Bernhard.Schmidt@lrz.de>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/sparse-vmemmap.c

index 1b7e22ab9b091bf34d857b5aeb36fd08039c0378..22b7e18e9dea5953a59b6aafd4f9bbb804c428db 100644 (file)
@@ -53,10 +53,12 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node)
                struct page *page;
 
                if (node_state(node, N_HIGH_MEMORY))
-                       page = alloc_pages_node(node,
-                               GFP_KERNEL | __GFP_ZERO, get_order(size));
+                       page = alloc_pages_node(
+                               node, GFP_KERNEL | __GFP_ZERO | __GFP_REPEAT,
+                               get_order(size));
                else
-                       page = alloc_pages(GFP_KERNEL | __GFP_ZERO,
+                       page = alloc_pages(
+                               GFP_KERNEL | __GFP_ZERO | __GFP_REPEAT,
                                get_order(size));
                if (page)
                        return page_address(page);