lkdtm: use generic_file_llseek in debugfs
authorArnd Bergmann <arnd@arndb.de>
Tue, 6 Jul 2010 17:10:26 +0000 (19:10 +0200)
committerArnd Bergmann <arnd@arndb.de>
Thu, 16 Sep 2010 08:33:09 +0000 (10:33 +0200)
When the default llseek behavior gets changed to
not allowing seek, all file operations that rely
on the current behaviour need to use an explicit
.llseek operation.

The files that lkdtm uses in debugfs are regular
files and they get read using simple_read_from_buffer,
so generic_file_llseek is the right operation.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/misc/lkdtm.c

index ef34de7a802606309fbaf02b8396456763fd4b62..343b5d8ea6971fc07ddbb443b91ddfee6439e31c 100644 (file)
@@ -575,30 +575,39 @@ struct crash_entry {
 
 static const struct crash_entry crash_entries[] = {
        {"DIRECT", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = direct_entry} },
        {"INT_HARDWARE_ENTRY", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = int_hardware_entry} },
        {"INT_HW_IRQ_EN", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = int_hw_irq_en} },
        {"INT_TASKLET_ENTRY", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = int_tasklet_entry} },
        {"FS_DEVRW", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = fs_devrw_entry} },
        {"MEM_SWAPOUT", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = mem_swapout_entry} },
        {"TIMERADD", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = timeradd_entry} },
        {"SCSI_DISPATCH_CMD", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = scsi_dispatch_cmd_entry} },
        {"IDE_CORE_CP", {.read = lkdtm_debugfs_read,
+                       .llseek = generic_file_llseek,
                        .open = lkdtm_debugfs_open,
                        .write = ide_core_cp_entry} },
 };