backlight: tdo24m: use devm_lcd_device_register()
authorJingoo Han <jg1.han@samsung.com>
Tue, 12 Nov 2013 23:09:32 +0000 (15:09 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 13 Nov 2013 03:09:20 +0000 (12:09 +0900)
Use devm_lcd_device_register() to make cleanup paths simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/backlight/tdo24m.c

index 2ccfa46eee7c14a410c3474e2db63952b88eba8a..908016fc5829ff3ef0667f5be62c51999d30106e 100644 (file)
@@ -385,21 +385,17 @@ static int tdo24m_probe(struct spi_device *spi)
                return -EINVAL;
        }
 
-       lcd->lcd_dev = lcd_device_register("tdo24m", &spi->dev,
-                                       lcd, &tdo24m_ops);
+       lcd->lcd_dev = devm_lcd_device_register(&spi->dev, "tdo24m", &spi->dev,
+                                               lcd, &tdo24m_ops);
        if (IS_ERR(lcd->lcd_dev))
                return PTR_ERR(lcd->lcd_dev);
 
        spi_set_drvdata(spi, lcd);
        err = tdo24m_power(lcd, FB_BLANK_UNBLANK);
        if (err)
-               goto out_unregister;
+               return err;
 
        return 0;
-
-out_unregister:
-       lcd_device_unregister(lcd->lcd_dev);
-       return err;
 }
 
 static int tdo24m_remove(struct spi_device *spi)
@@ -407,8 +403,6 @@ static int tdo24m_remove(struct spi_device *spi)
        struct tdo24m *lcd = spi_get_drvdata(spi);
 
        tdo24m_power(lcd, FB_BLANK_POWERDOWN);
-       lcd_device_unregister(lcd->lcd_dev);
-
        return 0;
 }