usb: gadget: f_loopback: eliminate abuse of ep->driver data

Since ep->driver_data is not used for endpoint claiming, neither for
enabled/disabled state storing, we can reduce number of places where
we read or modify it's value, as now it has no particular meaning for
function or framework logic.

In case of f_hid we only need to store in ep->driver_data pointer to
struct f_loopback, as it's used in loopback_complete() callback. All
other uses of ep->driver_data are now meaningless and can be safely
removed.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/gadget/function/f_loopback.c b/drivers/usb/gadget/function/f_loopback.c
index 6e2fe63b926741abf184f2ee54a0fe740a372e42..300e6011ae67ffeac8a49411bfca0e2e7f7d4510 100644 (file)
--- a/drivers/usb/gadget/function/f_loopback.c
+++ b/drivers/usb/gadget/function/f_loopback.c
@@ -195,12 +195,10 @@ autoconf_fail:
                        f->name, cdev->gadget->name);
                return -ENODEV;
        }
-       loop->in_ep->driver_data = cdev;        /* claim */
 
        loop->out_ep = usb_ep_autoconfig(cdev->gadget, &fs_loop_sink_desc);
        if (!loop->out_ep)
                goto autoconf_fail;
-       loop->out_ep->driver_data = cdev;       /* claim */
 
        /* support high speed hardware */
        hs_loop_source_desc.bEndpointAddress =
@@ -364,8 +362,7 @@ static int loopback_set_alt(struct usb_function *f,
        struct usb_composite_dev *cdev = f->config->cdev;
 
        /* we know alt is zero */
-       if (loop->in_ep->driver_data)
-               disable_loopback(loop);
+       disable_loopback(loop);
        return enable_loopback(cdev, loop);
 }