dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 24 Oct 2022 19:50:09 +0000 (21:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Nov 2022 16:35:36 +0000 (17:35 +0100)
[ Upstream commit 081195d17a0c4c636da2b869bd5809d42e8cbb13 ]

A clk_prepare_enable() call in the probe is not balanced by a corresponding
clk_disable_unprepare() in the remove function.

Add the missing call.

Fixes: 3cd2c313f1d6 ("dmaengine: mv_xor_v2: Fix clock resource by adding a register clock")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/e9e3837a680c9bd2438e4db2b83270c6c052d005.1666640987.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/mv_xor_v2.c

index be1f5c26fae8eacfaf248f8d22c2254200585a8f..9eb5647fef3e9c2789de2b6cdbdd624dd0d653cc 100644 (file)
@@ -847,6 +847,7 @@ static int mv_xor_v2_remove(struct platform_device *pdev)
        tasklet_kill(&xor_dev->irq_tasklet);
 
        clk_disable_unprepare(xor_dev->clk);
+       clk_disable_unprepare(xor_dev->reg_clk);
 
        return 0;
 }