powerpc/icp-hv: Fix missing of_node_put() in success path
authorNicholas Mc Guire <hofrat@osadl.org>
Wed, 4 Jul 2018 08:03:27 +0000 (10:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:07:08 +0000 (09:07 +0100)
[ Upstream commit d3e669f31ec35856f5e85df9224ede5bdbf1bc7b ]

Both of_find_compatible_node() and of_find_node_by_type() will return
a refcounted node on success - thus for the success path the node must
be explicitly released with a of_node_put().

Fixes: 0b05ac6e2480 ("powerpc/xics: Rewrite XICS driver")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1530691407-3991-1-git-send-email-hofrat@osadl.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/sysdev/xics/icp-hv.c

index bbc839a98c414906fcc193e98d495f1a6ca1c784..003deaabb568094b3d83ffa3e4d49dda79bdaebd 100644 (file)
@@ -179,6 +179,7 @@ int icp_hv_init(void)
 
        icp_ops = &icp_hv_ops;
 
+       of_node_put(np);
        return 0;
 }