call_usermodehelper: UMH_WAIT_EXEC ignores kernel_thread() failure
authorOleg Nesterov <oleg@redhat.com>
Wed, 26 May 2010 21:43:05 +0000 (14:43 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 27 May 2010 16:12:45 +0000 (09:12 -0700)
UMH_WAIT_EXEC should report the error if kernel_thread() fails, like
UMH_WAIT_PROC does.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/kmod.c

index ad9f2edebd673930c5fd034321f4f271305dda90..6e9b19667a8d2fdff6ac3c0bf76d32d8c1fc4d87 100644 (file)
@@ -235,10 +235,10 @@ static void __call_usermodehelper(struct work_struct *work)
        case UMH_WAIT_PROC:
                if (pid > 0)
                        break;
-               sub_info->retval = pid;
                /* FALLTHROUGH */
-
        case UMH_WAIT_EXEC:
+               if (pid < 0)
+                       sub_info->retval = pid;
                complete(sub_info->complete);
        }
 }