iwlwifi: mvm: fix incorrect fallthrough in iwl_mvm_check_running_scans()
authorNicholas Krause <xerofoify@gmail.com>
Wed, 23 Sep 2015 00:24:19 +0000 (20:24 -0400)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Tue, 1 Dec 2015 19:17:52 +0000 (21:17 +0200)
In the iwl_mvm_check_running_scans() we were mistakenly ignoring the
value returned by iwl_mvm_scan_stop() for scheduled scans and falling
thorugh to the next case, which caused us to always return zero.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/scan.c

index e8a79bff9c1bb167143395b9b15e9f762f775707..7cbfb085f60bc94a8346c6893ad6f4e60a404e3e 100644 (file)
@@ -1162,7 +1162,7 @@ static int iwl_mvm_check_running_scans(struct iwl_mvm *mvm, int type)
        case IWL_MVM_SCAN_SCHED:
                if (mvm->scan_status & IWL_MVM_SCAN_SCHED_MASK)
                        return -EBUSY;
-               iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_REGULAR, true);
+               return iwl_mvm_scan_stop(mvm, IWL_MVM_SCAN_REGULAR, true);
        case IWL_MVM_SCAN_NETDETECT:
                /* No need to stop anything for net-detect since the
                 * firmware is restarted anyway.  This way, any sched