scsi: hisi_sas: check SATA FIS when directly attaching SATA device
authorXiang Chen <chenxiang66@hisilicon.com>
Mon, 7 Nov 2016 12:48:38 +0000 (20:48 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Nov 2016 14:54:40 +0000 (09:54 -0500)
Check ERR bit of status to decide whether there is something wrong with
initial register-D2H FIS. If error exists, PHY reset the channel to
restart OOB.

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

index a5faa4d9a48b34cee48bed7477db04eba83bcefb..cda3baf9423dd1b1fcf7d2f564ed11edc6ef4fef 100644 (file)
@@ -2537,6 +2537,16 @@ static irqreturn_t sata_int_v2_hw(int irq_no, void *p)
                goto end;
        }
 
+       /* check ERR bit of Status Register */
+       if (fis->status & ATA_ERR) {
+               dev_warn(dev, "sata int: phy%d FIS status: 0x%x\n", phy_no,
+                               fis->status);
+               disable_phy_v2_hw(hisi_hba, phy_no);
+               enable_phy_v2_hw(hisi_hba, phy_no);
+               res = IRQ_NONE;
+               goto end;
+       }
+
        if (unlikely(phy_no == 8)) {
                u32 port_state = hisi_sas_read32(hisi_hba, PORT_STATE);