[media] cx88-dsp: Use kmalloc_array() in read_rds_samples()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/pci/cx88/cx88-dsp.c b/drivers/media/pci/cx88/cx88-dsp.c
index 7fafd132ccaf0e26847c5ff2b441169c927793c5..341e24432fab1932b1c60ac6dfa4b8461ae86dad 100644 (file)
--- a/drivers/media/pci/cx88/cx88-dsp.c
+++ b/drivers/media/pci/cx88/cx88-dsp.c
@@ -245,8 +245,7 @@ static s16 *read_rds_samples(struct cx88_core *core, u32 *N)
                current_address,
                current_address - srch->fifo_start, sample_count,
                cx_read(MO_AUD_INTSTAT));
-
-       samples = kmalloc(sizeof(s16)*sample_count, GFP_KERNEL);
+       samples = kmalloc_array(sample_count, sizeof(*samples), GFP_KERNEL);
        if (!samples)
                return NULL;