mac80211: fix queue selection for packets injected via monitor interface
authorLennert Buytenhek <buytenh@wantstofly.org>
Thu, 7 Jan 2010 14:01:42 +0000 (15:01 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 8 Jan 2010 20:49:15 +0000 (15:49 -0500)
Commit 'mac80211: fix skb buffering issue' added an ->ndo_select_queue()
for monitor interfaces which can end up dereferencing ieee802_1d_to_ac[]
beyond the end of the array for injected data packets (as skb->priority
isn't guaranteed to be zero or within [0:7]), which then triggers the
WARN_ON in net/core/dev.c:dev_cap_txqueue().  Fix this by always setting
the priority to zero on injected data frames.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Cc: stable@kernel.org
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/iface.c

index ff762ed34f1e9f1c4e42d4ca364d955d06f6b4e9..44188ef80a632c8c216832341816c6a3f71f3050 100644 (file)
@@ -685,6 +685,7 @@ static u16 ieee80211_monitor_select_queue(struct net_device *dev,
                return ieee802_1d_to_ac[skb->priority];
        }
 
+       skb->priority = 0;
        return ieee80211_downgrade_queue(local, skb);
 }