drm/i915/guc: enable GuC loading & submission by default
authorDave Gordon <david.s.gordon@intel.com>
Tue, 7 Jun 2016 08:14:51 +0000 (09:14 +0100)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Tue, 7 Jun 2016 13:21:58 +0000 (14:21 +0100)
The recent patch
fce91f2 drm/i915/guc: add enable_guc_loading parameter
enabled GuC loading and submission by default, but as issues
were found with warnings being issued during suspend-resume
cycles, GuC loading was disabled by default, by patch
2335986 drm/i915/guc: Disable automatic GuC firmware loading

Those warnings have been resolved, so this patch re-enables GuC
loading and submission by default.

Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1465287291-2187-1-git-send-email-david.s.gordon@intel.com
drivers/gpu/drm/i915/i915_params.c

index 5e18cf9f754d079914e5fb4b38f5425af9126a24..573e78723fc51418107776523da54b5153a5ec51 100644 (file)
@@ -54,8 +54,8 @@ struct i915_params i915 __read_mostly = {
        .verbose_state_checks = 1,
        .nuclear_pageflip = 0,
        .edp_vswing = 0,
-       .enable_guc_loading = 0,
-       .enable_guc_submission = 0,
+       .enable_guc_loading = -1,
+       .enable_guc_submission = -1,
        .guc_log_level = -1,
        .enable_dp_mst = true,
        .inject_load_failure = 0,
@@ -202,12 +202,12 @@ MODULE_PARM_DESC(edp_vswing,
 module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
 MODULE_PARM_DESC(enable_guc_loading,
                "Enable GuC firmware loading "
-               "(-1=auto, 0=never [default], 1=if available, 2=required)");
+               "(-1=auto [default], 0=never, 1=if available, 2=required)");
 
 module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
 MODULE_PARM_DESC(enable_guc_submission,
                "Enable GuC submission "
-               "(-1=auto, 0=never [default], 1=if available, 2=required)");
+               "(-1=auto [default], 0=never, 1=if available, 2=required)");
 
 module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
 MODULE_PARM_DESC(guc_log_level,