s390/vmlogrdr: fix IUCV buffer allocation
authorGerald Schaefer <gerald.schaefer@de.ibm.com>
Mon, 21 Nov 2016 11:13:58 +0000 (12:13 +0100)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:17:03 +0000 (13:17 +0000)
commit 5457e03de918f7a3e294eb9d26a608ab8a579976 upstream.

The buffer for iucv_message_receive() needs to be below 2 GB. In
__iucv_message_receive(), the buffer address is casted to an u32, which
would result in either memory corruption or an addressing exception when
using addresses >= 2 GB.

Fix this by using GFP_DMA for the buffer allocation.

Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/s390/char/vmlogrdr.c

index 9b3a24e8d3a0e0dfec9ffcbf1757ddd37f66329e..5e41e8453acd7e72ea4428a3b749446b0f6b644d 100644 (file)
@@ -873,7 +873,7 @@ static int __init vmlogrdr_init(void)
                goto cleanup;
 
        for (i=0; i < MAXMINOR; ++i ) {
-               sys_ser[i].buffer = (char *) get_zeroed_page(GFP_KERNEL);
+               sys_ser[i].buffer = (char *) get_zeroed_page(GFP_KERNEL | GFP_DMA);
                if (!sys_ser[i].buffer) {
                        rc = -ENOMEM;
                        break;