rxrpc: Purge the to_be_accepted queue on socket release
authorDavid Howells <dhowells@redhat.com>
Sat, 17 Sep 2016 09:49:11 +0000 (10:49 +0100)
committerDavid Howells <dhowells@redhat.com>
Sat, 17 Sep 2016 09:51:54 +0000 (10:51 +0100)
Purge the queue of to_be_accepted calls on socket release.  Note that
purging sock_calls doesn't release the ref owned by to_be_accepted.

Probably the sock_calls list is redundant given a purges of the recvmsg_q,
the to_be_accepted queue and the calls tree.

Signed-off-by: David Howells <dhowells@redhat.com>
net/rxrpc/call_object.c

index 22f9b0d1a138b4c01ea4d76964e9583aee04ace3..b0ffbd9664e66728fcc3dbb585bce30cb48762ef 100644 (file)
@@ -476,6 +476,16 @@ void rxrpc_release_calls_on_socket(struct rxrpc_sock *rx)
 
        _enter("%p", rx);
 
+       while (!list_empty(&rx->to_be_accepted)) {
+               call = list_entry(rx->to_be_accepted.next,
+                                 struct rxrpc_call, accept_link);
+               list_del(&call->accept_link);
+               rxrpc_abort_call("SKR", call, 0, RX_CALL_DEAD, ECONNRESET);
+               rxrpc_send_call_packet(call, RXRPC_PACKET_TYPE_ABORT);
+               rxrpc_release_call(rx, call);
+               rxrpc_put_call(call, rxrpc_call_put);
+       }
+
        while (!list_empty(&rx->sock_calls)) {
                call = list_entry(rx->sock_calls.next,
                                  struct rxrpc_call, sock_link);