ocfs2: potential ERR_PTR dereference on error paths
authorDan Carpenter <error27@gmail.com>
Thu, 22 Apr 2010 09:39:29 +0000 (11:39 +0200)
committerJoel Becker <joel.becker@oracle.com>
Fri, 23 Apr 2010 21:42:06 +0000 (14:42 -0700)
If "handle" is non null at the end of the function then we assume it's a
valid pointer and pass it to ocfs2_commit_trans();

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
fs/ocfs2/inode.c

index ab207901d32a28e2423019007e10da4ed5eb2a0f..23c254e26018bb7afd8e3d6648b294813214e5b1 100644 (file)
@@ -559,6 +559,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb,
                handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
                if (IS_ERR(handle)) {
                        status = PTR_ERR(handle);
+                       handle = NULL;
                        mlog_errno(status);
                        goto out;
                }