extcon: adc-jack: Fix checking return value of request_any_context_irq
authorAxel Lin <axel.lin@ingics.com>
Tue, 2 Oct 2012 00:14:59 +0000 (09:14 +0900)
committerMyungJoo Ham <myungjoo.ham@samsung.com>
Tue, 23 Oct 2012 07:32:13 +0000 (16:32 +0900)
On failure, request_any_context_irq() returns a negative value.
On success, it returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED.

Also ensure adc_jack_probe() return 0 on success.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-adc-jack.c

index 725eb5aa8d8cb670d0e104d48557fb866947a20a..2cc6bec9f625af3b20cf30f842dd34a95f1babce 100644 (file)
@@ -161,13 +161,12 @@ static int __devinit adc_jack_probe(struct platform_device *pdev)
        err = request_any_context_irq(data->irq, adc_jack_irq_thread,
                        pdata->irq_flags, pdata->name, data);
 
-       if (err) {
+       if (err < 0) {
                dev_err(&pdev->dev, "error: irq %d\n", data->irq);
-               err = -EINVAL;
                goto err_irq;
        }
 
-       goto out;
+       return 0;
 
 err_irq:
        extcon_dev_unregister(&data->edev);